fix(vault): postpone vault reference resolving on init_worker #12554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bungle
changed the title
bungle
force-pushed
the
fix/vault-init-worker
branch
4 times, most recently
from
eae2925 to
8f36975
Compare
bungle
force-pushed
the
fix/vault-init-worker
branch
from
8f36975 to
ab1f7f1
Compare
bungle
force-pushed
the
fix/vault-init-worker
branch
2 times, most recently
from
f25f212 to
dcea9f5
Compare
bungle
force-pushed
the
fix/vault-init-worker
branch
2 times, most recently
from
80d802d to
020818d
Compare
bungle
added
backport release/3.5.x
cherry-pick kong-ee
bungle
force-pushed
the
fix/vault-init-worker
branch
from
020818d to
62c6eb3
Compare
samugi
force-pushed
the
fix/vault-init-worker
branch
from
62c6eb3 to
80d059e
Compare
bungle
force-pushed
the
fix/vault-init-worker
branch
2 times, most recently
from
5dd048a to
e8a4df4
Compare
samugi
reviewed
Feb 15, 2024
bungle
force-pushed
the
fix/vault-init-worker
branch
2 times, most recently
from
f4f02d2 to
fe44553
Compare
### Summary It was reported on KAG-2907 that existing LMDB database with secrets can lead to an error when resolving secrets on init worker: ``` resty/http.lua:74: API disabled in the context of init_worker_by_lua* stack traceback: [C]: in function 'co_create' ``` This fixes the issue. Signed-off-by: Aapo Talvensaari <[email protected]>
bungle
force-pushed
the
fix/vault-init-worker
branch
from
fe44553 to
83232f5
Compare
team-eng-enablement
added
author/community
jschmid1
approved these changes
Feb 19, 2024
windmgc
approved these changes
Feb 20, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Feb 20, 2024
### Summary It was reported on KAG-2907 that existing LMDB database with secrets can lead to an error when resolving secrets on init worker: ``` resty/http.lua:74: API disabled in the context of init_worker_by_lua* stack traceback: [C]: in function 'co_create' ``` This fixes the issue. Signed-off-by: Aapo Talvensaari <[email protected]> (cherry picked from commit 9a7498c)
Merged
3 tasks
|
Cherry-pick failed for Please cherry-pick the changes locally. git remote add upstream https://github.com/kong/kong-ee
git fetch upstream master
git worktree add -d .worktree/cherry-pick-12554-to-master-to-upstream upstream/master
cd .worktree/cherry-pick-12554-to-master-to-upstream
git checkout -b cherry-pick-12554-to-master-to-upstream
ancref=$(git merge-base 84cb1be01d8e9a241e8a2b3afd6d55bb184e605b 83232f50cb65a687f139c7767ef387c3ce10e853)
git cherry-pick -x $ancref..83232f50cb65a687f139c7767ef387c3ce10e853 |
|
Successfully created backport PR for |
github-actions bot
pushed a commit
that referenced
this pull request
Feb 20, 2024
### Summary It was reported on KAG-2907 that existing LMDB database with secrets can lead to an error when resolving secrets on init worker: ``` resty/http.lua:74: API disabled in the context of init_worker_by_lua* stack traceback: [C]: in function 'co_create' ``` This fixes the issue. Signed-off-by: Aapo Talvensaari <[email protected]> (cherry picked from commit 9a7498c)
Merged
3 tasks
|
Successfully created backport PR for |
windmgc
pushed a commit
that referenced
this pull request
Mar 5, 2024
### Summary It was reported on KAG-2907 that existing LMDB database with secrets can lead to an error when resolving secrets on init worker: ``` resty/http.lua:74: API disabled in the context of init_worker_by_lua* stack traceback: [C]: in function 'co_create' ``` This fixes the issue. Signed-off-by: Aapo Talvensaari <[email protected]> (cherry picked from commit 9a7498c)
windmgc
pushed a commit
that referenced
this pull request
Mar 5, 2024
### Summary It was reported on KAG-2907 that existing LMDB database with secrets can lead to an error when resolving secrets on init worker: ``` resty/http.lua:74: API disabled in the context of init_worker_by_lua* stack traceback: [C]: in function 'co_create' ``` This fixes the issue. Signed-off-by: Aapo Talvensaari <[email protected]> (cherry picked from commit 9a7498c)
tysoekong
pushed a commit
that referenced
this pull request
Apr 26, 2024
It was reported on KAG-2907 that existing LMDB database with secrets can lead to an error when resolving secrets on init worker: ``` resty/http.lua:74: API disabled in the context of init_worker_by_lua* stack traceback: [C]: in function 'co_create' ``` This fixes the issue. Signed-off-by: Aapo Talvensaari <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
It was reported on KAG-2907 that existing LMDB database with secrets can lead to an error when resolving secrets on init worker:
This fixes the issue by postponing the resolving to a timer.
Checklist
changelog/unreleased/kongorskip-changeloglabel added on PR if changelog is unnecessary. README.mdIssue reference
https://konghq.atlassian.net/browse/KAG-2907